If a site over links to itself then they are most likely creating a bad user experience. When it comes to internal links, I would always but more priority on taxonomy and the user experience, the SEO would be a result of that.
Natural, diverse links from highly trusted sources is what comes to mind when I think about link building.